tremor-rs / tremor-runtime

Main Tremor Project Rust Codebase
https://www.tremor.rs
Apache License 2.0
866 stars 125 forks source link

User-agent extractor/function #1483

Open darach opened 2 years ago

darach commented 2 years ago

Describe the problem you are trying to solve

As a user, I would like an extractor/function to dissect HTTP user agent headers

Describe the solution you'd like

Something along the lines of logstash's user-agent plugin: https://www.elastic.co/guide/en/logstash/current/plugins-filters-useragent.html

Licenser commented 2 years ago

Should this perhaps rather be a tremor function instead of a extractor? We do support all the needed logic already and can avoid adding one-of-a-kind extractors this way.

darach commented 2 years ago

Yep - a function would be fine too - updating issue

darach commented 2 years ago

There are many standard headers that we could have util functions for - like repeated headers, content-type/mime, accept ...

Licenser commented 2 years ago

I love that idea, a http module with the common logic would be absolutely great!

mfelsche commented 2 years ago

And it would make for great first issues too :D

darach commented 2 years ago

Each connector should probably have its own module of utilities - it worked well for otel ...

tobehardest commented 1 year ago

Does this problem still need to be solved? I'd like to try it out if I can.

Licenser commented 1 year ago

Heya,

yes it does and it should be a good issue to start with, I'll assign it to you, feel free to hop by https://chat.tremor.rs if you need any help or pointers :)

Licenser commented 1 year ago

heya @tobehardest do you need any help from us?

Licenser commented 1 year ago

unassigning this again due to lack of response