Open darach opened 2 years ago
This would be solved by giving an ArenaEntry
(this is where we keep the loaded sources, so we can reference them in our AST and interpreter (e.g. string literals)) an optional field file_name
that can be loaded upon error reporting.
Not quit, since the entries can represent multiple files from different load paths, but it would at least point to a file then, however w/ the archives, that won't work since it'll be be dependant on the host it's packaged on.
that said in the raft
branch we alreadyu store the path info for modules, if that helps? Might be a decent halfway house?
We should fix this before we introduce clustering imho.
We should fix that in a way that works with clustering. Otherwise, the work will become pointless with the release. But please look at the changes to module in the raft
branch it makes little sense to do the work from scratch twice in conflicting ways.
In
v0.12.0-rc2
modular tremor applications will begin to get errors from modules and we currently do not emit the filename and module relative path in hygienic errors.In the example above we are implicitly directed to
discord.troy
but this is not the file from whence the error originates. Tremor should always indicate the file from which an error originates in a modular application.Describe the problem you are trying to solve
Describe the solution you'd like
Indicating the location on the module path as a fully qualified file path would allow opening the file in a modern IDE via a quick link for editing and fixing.
Notes