tremor-rs / tremor-runtime

Main Tremor Project Rust Codebase
https://www.tremor.rs
Apache License 2.0
851 stars 126 forks source link

tremor-runtime 0.12.4 failed to build against rust 1.75.0 #2443

Closed chenrui333 closed 5 months ago

chenrui333 commented 8 months ago

While upgrading rust to 1.75.0, seeing the similar macro match failures

error: no rules expected the token `:`
   --> tremor-script/src/std_lib/stats.rs:466:19
    |
466 |           let res = literal!({
    |  ___________________^
467 | |             "count": count,
468 | |             "sum": sum,
469 | |             "min": min,
...   |
472 | |             "percentiles": p
473 | |         });
    | |__________^ no rules expected this token in macro call
    |
note: while trying to match `=>`
   --> /private/tmp/tremor-runtime-20240101-65510-octqn0/tremor-runtime-0.12.4/tremor-value/src/macros.rs:187:46
    |
187 |     (@object @count [@entries $(($value:expr => $($key:tt)+))*]) => {
    |                                              ^^
    = note: this error originates in the macro `literal_internal` which comes from the expansion of the macro `literal` (in Nightly builds, run with -Z macro-backtrace for more info)

error: no rules expected the token `:`
   --> tremor-script/src/std_lib/stats.rs:698:12
    |
698 |           Ok(literal!({
    |  ____________^
699 | |             "count": histo.len(),
700 | |             "min": histo.min(),
701 | |             "max": histo.max(),
...   |
705 | |             "percentiles": p,
706 | |         }))
    | |__________^ no rules expected this token in macro call
    |
note: while trying to match `=>`
   --> /private/tmp/tremor-runtime-20240101-65510-octqn0/tremor-runtime-0.12.4/tremor-value/src/macros.rs:187:46
    |
187 |     (@object @count [@entries $(($value:expr => $($key:tt)+))*]) => {
    |                                              ^^
    = note: this error originates in the macro `literal_internal` which comes from the expansion of the macro `literal` (in Nightly builds, run with -Z macro-backtrace for more info)

relates to https://github.com/Homebrew/homebrew-core/pull/158492

darach commented 5 months ago

Closing as fixed. Tremor generally tracks latest rust stable updates and we use pedantic or strict lints. So a new often trip up after a new rust release which we quickly attend to.