tremorlabs / tremor-raw

Copy & Paste React components to build modern web applications.
https://tremor.so
Apache License 2.0
778 stars 19 forks source link

Added `cursor-not-allowed` to `Button` component `disabled` styles #4

Closed NuroDev closed 6 months ago

NuroDev commented 6 months ago

Description

A tiny one line tweak to the Button component's disabled styles to make the cursor be marked as not-allowed.

Related issue(s)

N/A

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

For now this is a "quick fix" PR but & have not tested this myself, but considering this is a one line change that matches what the Tailwind CSS documentation outlines the required classes for a not-allowed cursor, this should be fine.

Screenshots (if appropriate):

The PR fulfils these requirements:

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-raw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 1:23pm
severinlandolt commented 6 months ago

Hi @NuroDev, thanks for creating this PR!

We had this cursor-not-allowed discussion two weeks ago. Because we wanted to have the same behaviour across all inputs/components that can be disabled. We decided to not add this class, and stick to the html default.

Fun fact: The default html button does not have any cursor-pointer style. Also only cursor-default for all states.

Thanks for your PR nonetheless, happy coding ⌨️