adnjoo commented 1 month ago

Description

Changed the class from focus:ring-0 to focus:ring to improve keyboard navigation and accessibility in the Tab component.

Another class idea I had was focus:ring-1 rounded-t, which would have slightly softer features

Related issue(s)

305

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Visual UI/UX test using storybook npm run storybook

Screenshots (if appropriate):

MacBook Pro Sonoma 14.2.1 Chrome Version 123.0.6312.87 (Official Build) (arm64)

The PR fulfils these requirements:

[x] It's submitted to the main branch
[x] When resolving a specific issue, it's referenced in the related issue section above
[ ] My change requires a change to the documentation. (Managed by Tremor Team)
[ ] I have added tests to cover my changes
[x] Check the "Allow edits from maintainers" option while creating your PR.
[x] Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
[x] By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tremor-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 3, 2024 5:23am

severinlandolt commented 1 month ago

Thanks, will check this out this week!

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 3.15.1-beta-tabfixes.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tremorlabs / tremor