tremorlabs / tremor

React components to build charts and dashboards
https://npm.tremor.so
Apache License 2.0
16.22k stars 467 forks source link

[Advice]: A Lot of `console.log` messages #1130

Closed raisiqueira closed 2 months ago

raisiqueira commented 2 months ago

Tremor Version

3.18.0

Link to minimal reproduction

CodeSandbox link

Steps to reproduce

What is expected?

Do not spam the dev console with messages that the component also includes a version that you can copy/paste the code.

What is actually happening?

OK guys, I know that you all want to share your new project, but adding spam messages into the development console is not the best way to do that. Every tremor component that I use, many messages appear on the console. Really that you guys think that it is a good strategy?

At least use a React Context or an environment variable to let the developers disable these messages.

I'm using Tremor for a personal project, but imagine those that are using the @tremor/react package for company projects. For now, I'm removing it from my project.

https://github.com/tremorlabs/tremor/blob/f46e297c6b553db8f463634c751f3f75efde4bb0/src/components/input-elements/Button/Button.tsx#L122-L126

What browsers are you seeing the problem on?

Chrome, Microsoft Edge, Safari, Firefox

Any additional comments?

No response

github-actions[bot] commented 2 months ago

:tada: This issue has been resolved in version 3.18.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: