tremorlabs / tremor

React components to build charts and dashboards
https://npm.tremor.so
Apache License 2.0
16.18k stars 465 forks source link

[Bug]: Theming won't apply to ProgressBar component in v3.1.0 #522

Closed vishalkdotcom closed 1 year ago

vishalkdotcom commented 1 year ago

Tremor Version

3.1.0

Link to minimal reproduction

https://github.com/vishalkdotcom/progressbar-theme-bug-repro

Steps to reproduce

Just follow the official installation (Next.js) and theming guide. And don't provide the color attribute to ProgressBar. You can also check the github repo to reproduce this issue.

Installation https://www.tremor.so/docs/getting-started/installation

Theming https://www.tremor.so/docs/getting-started/theming

What is expected?

ProgressBar colors should change as per the brand colors in tailwind.config.js

What is actually happening?

ProgressBar colors remain blue

What browsers are you seeing the problem on?

No response

Any additional comments?

If you try the repro example I provided, the theming works on Badge component but not on ProgressBar.

I believe this issue occurs because there is a default color passed during props destructuring at line #23.

vishalkdotcom commented 1 year ago

I spent a lot of time today in debugging this. I was thinking the issue is at my end (pnpm, npm or stale packages etc). 😅

This issue could exist in other components as well. But I didn't get time to check.

severinlandolt commented 1 year ago

Hi! There is an issue on our end. We are working on it!

severinlandolt commented 1 year ago

Should work now: npm i @tremor/react@latest

vishalkdotcom commented 1 year ago

@severinlandolt Thanks a lot, not only for this specifc bugfix, but for all the amazing work being done on this brilliant library.

Greg-Mukuria commented 11 months ago

What of pnpm?