search

trendmicro-frontend / tonic-ui

Tonic UI is a UI component library for React, built with Emotion and Styled System. It is designed to be easy to use and easy to customize.
https://trendmicro-frontend.github.io/tonic-ui
MIT License
125 stars 29 forks source link

fix(react/OverflowTooltip): show the tooltip only when the string is truncated and the `disabled` prop is not true #913

Closed tinaClin closed 3 months ago

tinaClin commented 3 months ago

The tooltip should be shown only if the string is truncated when the disabled prop is false.

Issue: https://github.com/trendmicro-frontend/tonic-ui/issues/912

codesandbox[bot] commented 3 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 670cb962fc8faa56a49db001a3598f8e4720fe8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | @tonic-ui/react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

trendmicro-frontend-bot commented 3 months ago

Tonic UI Demo

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.82%. Comparing base (807bfc0) to head (670cb96). Report is 1 commits behind head on v2.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #913 +/- ## ========================================== - Coverage 78.84% 78.82% -0.02% ========================================== Files 378 378 Lines 6168 6168 ========================================== - Hits 4863 4862 -1 - Misses 1305 1306 +1 ``` | [Flag](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | Coverage Δ | | |---|---|---| | [-base](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [-github](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [-hooks](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [-icons](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [-system](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [codemod](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [react](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [theme](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | | [utils](https://app.codecov.io/gh/trendmicro-frontend/tonic-ui/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend) | `78.82% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trendmicro-frontend#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.