search

trendmicro / cloudone-container-security-helm

Helm chart for Trend Micro Cloud One Container Security
Other
18 stars 16 forks source link

Collect logs context switch #3

Open Hounddog opened 1 year ago

Hounddog commented 1 year ago

It is required for us to set the context in the logs to select which cluster should be used. I have removed the need to use Environment variables and instead provide parameters. (Similar to smartcheck implementation) I have implemented a context switch to switch between prod and staging Kubernetes cluster.

The Readme has been updated to Reflect the changes. I was able to use this locally to provide logs to your support team.

Hounddog commented 1 year ago

Thank you for the Review. I have seen that i missed removing the resultdir flag and the corefile pattern. Removed these lines from the help

holyspectral commented 1 year ago

Hi @Hounddog, thanks for contributing. Can you elaborate more about your use case where you can't use environment variables to specify release and namespace?

Hounddog commented 1 year ago

I have no reason for this. My only concern here is that smartcheck has a similar script and uses parameters instead of environment variables.

I personally also feel that i am more flexible with parameters to change them as required