trendmicro / cloudone-filestorage-deployment-templates

Apache License 2.0
16 stars 33 forks source link

feat(documentation): Improvements in the required permissions #86

Closed felipecosta09 closed 2 years ago

felipecosta09 commented 2 years ago

Proposed Changes

felipecosta09 commented 2 years ago

Looks good couple of minor chages.

Thanks a lot for the commits, all very helpful!

All done!

felipecosta09 commented 2 years ago

You missed a suggested change - line 23. Otherwise looks good. Please fix.

Hi @davidblanchard123 The line 23 is showing that your suggestion in pending in the review but if you go to the file, the change was made already: https://github.com/trendmicro/cloudone-filestorage-deployment-templates/blob/f8402f37e2ca96504f9a92c5ae07432d7c7ed88c/aws/required-permissions.md