search

trendmicro / cloudone-filestorage-plugins

Trend Micro Cloud One File Storage Security plugins reference code.
https://cloudone.trendmicro.com
Apache License 2.0
42 stars 51 forks source link

Fixed multiple full scan AWS buckets scanning deployment name conflict #128

Open samthesecret opened 1 year ago

samthesecret commented 1 year ago

TITLE

Change Summary

PR Checklist

Other Notes

This is resolution against the bug https://github.com/trendmicro/cloudone-filestorage-plugins/issues/121

trend-jack-c-tang commented 1 year ago

The issue related to this PR should be https://github.com/trendmicro/cloudone-filestorage-plugins/issues/120

samthesecret commented 1 year ago

Thanks for the correction on bug number, I missed attaching the correct one.

I have resolved the conflict.

Shall I make change to control the step function length ?

trend-jack-c-tang commented 1 year ago

Shall I make change to control the step function length ?

Yes, this should be addressed, or it won't work for longer bucket name. I'd suggest not giving default name for the step function. What do you think?

samthesecret commented 1 year ago

I have made changes to make sure the length of StateMachine function should be in limit.