trendmicro / cloudone-filestorage-plugins

Trend Micro Cloud One File Storage Security plugins reference code.
https://cloudone.trendmicro.com
Apache License 2.0
42 stars 51 forks source link

Add VPC, KMS, and PermissionsBoundary support for AWS promote or quarantine plugin #139

Closed jmlake569 closed 1 year ago

jmlake569 commented 1 year ago

Add VPC, KMS, and PermissionsBoundary support for AWS promote or quarantine plugin

Change Summary

PR Checklist

Other Notes

added support for KMS, VPC)su

jmlake569 commented 1 year ago

Not sure I understand the conflicts. I added new logic to support KMS, VPC, and permission boundary support.

felipecosta09 commented 1 year ago

Hey @jack-c-tang, Can you review this one?

I made some changes in the template and cleared the conflicts.

This PR should solve these 3 issues below...

trend-jack-c-tang commented 1 year ago

Hey @jack-c-tang, Can you review this one?

I made some changes in the template and cleared the conflicts.

This PR should solve these 3 issues below...

Thank you for remind. I'll check it.

felipecosta09 commented 1 year ago

Hi @jmlake569, sorry for the delay of the review. The plugin is tested to be working fine. Just a suggestion to ensure the extensibility to the KMSKeyARN parameter. And please remember to update the deployment parameters in other-installation-methods.md.

If you don't have time to finish the PR anymore, please let me know so that I can continue the PR. Thanks.

I'm taking over this one in @jmlake569 behalf, I will make the necessary changes!

felipecosta09 commented 1 year ago

Hi @jmlake569, sorry for the delay of the review. The plugin is tested to be working fine. Just a suggestion to ensure the extensibility to the KMSKeyARN parameter. And please remember to update the deployment parameters in other-installation-methods.md. If you don't have time to finish the PR anymore, please let me know so that I can continue the PR. Thanks.

Let me know if the instructions on the other-installation-methods.md are sufficient...

felipecosta09 commented 1 year ago

@jack-c-tang before merging, please fix the name of the PR to follow the Conventional Commit specification adding a feat:, since @jmlake569 is the creator, I can't change that myself.

felipecosta09 commented 1 year ago

@jack-c-tang

felipecosta09 commented 1 year ago

all fixed @jack-c-tang

felipecosta09 commented 1 year ago

all fixed @jack-c-tang

👀 @jack-c-tang