trendmicro / tlsh

Other
726 stars 135 forks source link

Library will not compile on CENTOS 7 (use of threads) #116

Closed jonjoliver closed 2 years ago

jonjoliver commented 2 years ago

compilation error

src/tlsh_impl.cpp:436:3: error: ‘thread’ is not a member of ‘std’ std::thread t1(thread1);

It appears that gcc for CENTOS 7 does not support threading https://stackoverflow.com/questions/2519607/stdthread-error-thread-not-member-of-std/2520980 There are work arounds https://answers.opencv.org/question/194036/how-to-enable-multi-thread-in-cmake-centos/ We do not want people compiling and installing C compilers to compile TLSH We will need to make threading a compilation OPTION for advanced users

jonjoliver commented 2 years ago

The use of stdc++ also causes issues on CENTOS 7

/usr/bin/ld: cannot find -lstdc++ collect2: error: ld returned 1 exit status

It appears we need to remove set(CMAKE_EXE_LINKER_FLAGS "-static-libstdc++") for CENTOS 7