search

trendmicro / tlsh

Other
732 stars 136 forks source link

JavaScript port 512-byte Requirement vs Python's 50-byte #132

Open Szejke opened 1 year ago

Szejke commented 1 year ago

JavaScript port for TLSH doesn't support the same minimum byte size for characters as its Python counterpart. Are there plans to update the JS port to match the behavior found in the Python version?

For clarity, in Python the minimum byte size is 50 bytes. However, in JS it's set to 512 bytes because each character is represented using 2 bytes. This means that in JS, I need to provide a minimum of 256 characters to meet the byte requirement. This discrepancy can lead to inconsistencies when using TLSH across different environments.

Thank you for considering this update!

jonjoliver commented 8 months ago

Hi Szejke

I left Trendmicro just over 2 years ago. I am jumping in to see what I can do here. Do you have a suggested pull request? And I will check it - and merge it or find someone who can

Cheers jono

HydraDragonAntivirus commented 8 months ago

You can change .dll to .exe via settings.

jonjoliver commented 8 months ago

Hi HydraDragonAntivirus

I think you have entered this comment (about .dll and .exe) in the incorrect issue. This issue is about JavaScript. To resolve this issue I need a pull request

Cheers jono

HydraDragonAntivirus commented 8 months ago

I posted to wrong issue probably.