trendmicro / tlsh

Other
726 stars 135 forks source link

PyPy (alternate python runtime) compatibility? #98

Closed bollwyvl closed 2 years ago

bollwyvl commented 3 years ago

Hi folks, thanks for this project!

I'm an (accidental) maintainer of this downstream on conda-forge (i'm mostly interested in a further downstream diffoscope, but do try to keep the ship running), and would love to be able to use it with pypy.

I have no idea at what level the incompatibility exists, and don't imagine I have the skills (or the extra bandwidth to do learn them at the moment) to offer any real insight into it, so this is definitely a feature request!

Some data, though: we have two automated requests open to support pypy36 and pypy37 that fail with compiler errors I don't recognize, but perhaps spur someone's thoughts?

Semi-related:

jonjoliver commented 3 years ago

Hi Nicholas

I will try to look at this and resolve it

cheers jono

jonjoliver commented 3 years ago

sorry I neglected this. I just released a new package $ pip install -i https://test.pypi.org/simple/ py-tlsh==4.7.0 Could you provide more details about the compiler errors/ problems you are having

jonjoliver commented 3 years ago

Version 4.7.2 is now at https://pypi.org/project/py-tlsh/ It is working for me. I changed the Python version required to 2.7 I added further Python Regression tests

Could you provide more details about the compiler errors/ problems you are having

jonjoliver commented 2 years ago

I believe this was resolved in 4.7.2 (I have not heard anything to the contrary)

bollwyvl commented 2 years ago

Cool! I'll try to coax our migration bot into trying again on conda-forge.