search

trendscenter / Coinstac_VBM_computation

This algorithm runs the Voxel Based Morphometry on structural T1 weighted MRI scans using SPMv12 and MATLAB Runtimev713.
3 stars 0 forks source link

Include the next lines as part of the __init__ function in the entity #16

Closed everner-ds closed 6 years ago

everner-ds commented 6 years ago

Your entities are pretty thin wrappers around objects from other libraries. I think it would be nice to handle these lines within the constructor for the entity. You can pass in the parameters when you instantiate the object.

https://github.com/MRN-Code/Coinstac_VBM_computation/blob/0f1b9db6567d583d9c4b67ab4664a14c1fbe87ca/vbm_use_cases_layer.py#L92

spanta28 commented 6 years ago

In this case, would it not conflict with the idea of entities layer isolation from use cases layer or interface layer?