search

trendwerk / sphynx

A light & simple WordPress starter theme 😽
16 stars 2 forks source link

Replace Fancybox with Photoswipe #416

Open gewoonderrik opened 9 years ago

gewoonderrik commented 9 years ago

Seems like a more modern solution because it has touch screen support. File size is 10kb less than fancybox.min.js.

luukdv commented 9 years ago

Sounds good, should be tested if it's working as intended on all devices.

haroldangenent commented 9 years ago

@luukdv will research this.

sboerrigter commented 9 years ago

I find fancybox nicer qua UI.

luukdv commented 8 years ago

Reopening this to investigate. Fancybox is getting outdated (https://github.com/trendwerk/trendpress/issues/312#issuecomment-64886827). Maybe https://github.com/sachinchoolur/lightgallery.js/.

sboerrigter commented 8 years ago

I still think the Fancybox UI is better because it is simpeler and has huge clickable area's. You can click left / right on an image for previous / next image and outside of an image to close it. Is there an alternative with the same simple UI?

sboerrigter commented 8 years ago

Maybe http://www.frescojs.com/ or http://osvaldas.info/image-lightbox-responsive-touch-friendly?

marthesselink commented 8 years ago

Decided to use Photoswipe

sboerrigter commented 7 years ago

We should also remove the Base64 Gulp task after Fancybox is removed (See: https://github.com/trendwerk/sphynx/issues/794).