search

trendwerk / sphynx

A light & simple WordPress starter theme 😽
16 stars 2 forks source link

Move information from Wiki to Readme #797

Closed sboerrigter closed 7 years ago

sboerrigter commented 7 years ago

Fixes #754. Don't forget to remove the Wiki after this PR is merged.

sboerrigter commented 7 years ago

Don't forget to remove the Wiki after this PR is merged.

sboerrigter commented 7 years ago

I think that the image is out of scope. I personally don't really like the image (sorry).

luukdv commented 7 years ago

https://github.com/trendwerk/sphynx/issues/754#issuecomment-286430794 we can always replace it when there's something better. 😺

sboerrigter commented 7 years ago

I still disagree, but I've added it anyway since it is 2 vs 1.

luukdv commented 7 years ago

Nice, but did you properly test this? Because it looks way too big now, with excessive whitespace below and above the image. Was thinking more like Moon, don't you agree?

haroldangenent commented 7 years ago

I like moon's README header as well. Also Ava.

sboerrigter commented 7 years ago

You suggested to use the image we currently have, so that is what I did. I agree that is is a bit big, but like you said: we can always replace it when there's something better. 😺

luukdv commented 7 years ago

Sigh. Just remove it and I'll approve.

haroldangenent commented 7 years ago

@sboerrigter Can the Wiki be removed now?

sboerrigter commented 7 years ago

Yes, I just did. Thanks for the reminder.