trendwerk / sphynx

A light & simple WordPress starter theme 😽
16 stars 2 forks source link

Base line height #814

Closed luukdv closed 7 years ago

luukdv commented 7 years ago

A recurring issue in test results of projects based on this theme is the line-height of elements. In a lot of cases, it's too big. The base line-height is 2, which is good for body text, and body text only. For all other things, it's (way) too high and should be 1.4 or 1.5. My proposal is to set the base line-height to one of these values, and keep 2 for the main content only.

Right now, I'm noticing a pattern in my styles where the line-height is reset at the base of the component most of the times. This indicates a problem.

.component {
  line-height: 1.5em;

  ...
}