search

trentforkert / cmake

Experimental CMake with D support
Other
16 stars 2 forks source link

Please update to latest cmake #26

Open KingDuckZ opened 6 years ago

KingDuckZ commented 6 years ago

As per the title, is it possible to merge the latest cmake into this repo? I've attempted a merge myself, it's not simple since they seem to have reformatted their code upstream. I was still able to work my way through most of the conflicts (maybe) but I have three files that look a bit messy. Not sure if there's any way I can share an unfinished merge, but maybe it will be quicker for you @trentforkert?

KingDuckZ commented 6 years ago

I've merged up to cmake 3.3 here https://github.com/KingDuckZ/cmake. I've done some build fixes, but it's very hard since I don't know the codebase at all. I'm stuck on this error now:

cmake/Source/cmNinjaTargetGenerator.cxx:200:32: error: ‘IsMinGW’ is not a member of ‘cmGlobalNinjaGenerator’ if(cmGlobalNinjaGenerator::IsMinGW())

I don't know what became of IsMinGW(), any pointer would be appreciated. Also, I'm not sure I'll succeed/I'll have the time to finish, I think they did a complete code refactoring in upstream's cmake at some point, and that's going to be annoying to merge, so no promises.

@trentforkert what happened to you? did you abandon github?

mcandre commented 5 years ago

By the way, the presence of an MSYSTEM environment variable is a decent way to manually detect MinGW/cygwin environments. Hope that helps!