search

trentlarge / partioapp

0 stars 1 forks source link

[CLOSED] Set Meet up location #60

Closed trentlarge closed 8 years ago

trentlarge commented 8 years ago

Issue by amdiyala Friday Sep 11, 2015 at 17:09 GMT Originally opened as https://github.com/insaneinc01/partio/issues/57

Set meet up locations isn't grabbing/storing the desired location to meet which is set by the user.

Needs Enhancements,I guess.

trentlarge commented 8 years ago

Comment by tallestms Friday Sep 11, 2015 at 17:14 GMT

Nikesh, are you in the borrowed side or renter side? In our logic, the renter will be responsible for setting that while the borrower will only access the map after the renter decided that.

trentlarge commented 8 years ago

Comment by amdiyala Friday Sep 11, 2015 at 17:22 GMT

I was on the renter side,Talles , when trying to replicate it. Question Is the renter responsible for setting the location for renting as well as for collecting the book?

trentlarge commented 8 years ago

Comment by tallestms Friday Sep 11, 2015 at 17:25 GMT

That is a good question. I think we can decide that it should be.

One of the two have to be responsible for both (rent/collect) in order to avoid confusion and it makes more sense to set the renter as that person.

trentlarge commented 8 years ago

Comment by amdiyala Friday Sep 11, 2015 at 17:36 GMT

okie, got your point.

Suggestion I guess the renting location point should be set by the borrower, as he is the one who needs the book. And where as the collecting point should be set by the collector as its his thing to get the book back. Correct me if I am wrong.

trentlarge commented 8 years ago

Comment by tallestms Friday Sep 11, 2015 at 17:43 GMT

It's complicated to define it. From our discussion we thought that since the borrower is "desperate" for the item, he can go wherever the renter is to get the item as soon as possible, if that is necessary (imagine I need a calculator for a test 2 hours from now).

The other way around, on the collecting part, I do not have an opinion right now but I thought about sticking with the same solution for easiness in implementation and in the user experience as well.

Let me know what you think.

trentlarge commented 8 years ago

Comment by nishanth-saka Saturday Sep 12, 2015 at 09:47 GMT

Talles, we should stick to your earlier decision of letting only the owner decide the meetup location. For the guy who's taking the book, the location will be read-only. Its implemented that way right now. (maybe its not showing correctly at the moment, which we'll fix anyway)

trentlarge commented 8 years ago

Comment by amdiyala Friday Sep 18, 2015 at 14:20 GMT

Closing!

trentlarge commented 8 years ago

Comment by tallestms Wednesday Sep 23, 2015 at 14:53 GMT

Map is not ideal yet. There should always be a blue dot in my current location and the arrow to the set location should remain set. Right now I can set the location I want to meet but it disappears after I open the map again.

trentlarge commented 8 years ago

Comment by amdiyala Wednesday Oct 21, 2015 at 12:50 GMT

fixed!