trentm / python-markdown2

markdown2: A fast and complete implementation of Markdown in Python
Other
2.66k stars 433 forks source link

Add <thead> tag to html-classes extra #500

Closed animator closed 1 year ago

animator commented 1 year ago

PR to add <thead> tag to html-classes extra to support html classes for the header row of the table.

nicholasserra commented 1 year ago

Thanks! Looks like it's failing that test. Not immediately obvious as to why to me. Did they pass locally?

animator commented 1 year ago

Figured out the issues and updated the code to fix thead rendering for wikitables.

% python3 test.py html_classes
WARNING:test:skipping pygments<2.14 tests (pygments 2.14.0 found)
WARNING:test:skipping wavedrom tests ('wavedrom' module not found)
markdown2/tm/html_classes [extras, html-classes, code.as.com] ... ok

----------------------------------------------------------------------
Ran 1 test in 0.005s

OK

PS: Thanks for maintaining this package, we use it to render foss42 - Open Source APIs project docs. You can check out a sample page - here (markdown source of this page here). I came across this issue when I was trying to style the table headers of the page.

nicholasserra commented 1 year ago

Thanks!