search

trento-project / trento

An open cloud-native web console improving on the work day of SAP Applications administrators.
https://www.trento-project.io
Apache License 2.0
33 stars 25 forks source link

check 1.1.9 (DA114A): to scan node-directives for both rings #911

Closed fmherschel closed 2 years ago

fmherschel commented 2 years ago

Instead of counting the string "interface" the test needs to scan the corosync.conf file for the directices node { ... }. There must be exact 2 such node-directives for the current se case and each of the entries needs exact two ring-addresses to be configured. The perl-snipset outputs a "2" per found node-directive (if exactly 2 rings are found). So the correct result following the best practice is "22" (both name-directives have exact two ring-address definitions).

stefanotorresi commented 2 years ago

note to self: needs forward-port into runner

pirat013 commented 2 years ago

Looks good for me. I vote to merge this PR.

stefanotorresi commented 2 years ago

implemented in https://github.com/trento-project/runner/pull/38