trento-project / web

The companion web app for SUSE Linux Enterprise Server for SAP Applications
https://trento-project.io
Other
33 stars 15 forks source link

Activity log add pagination #2930

Closed balanza closed 1 month ago

balanza commented 2 months ago

This PR allows browsing the entire activity log by scrolling different pages.

Key features:

balanza commented 2 months ago

changing filters should keep previously applied pagination

I added such a requirement to prevent unclear experiences for users, but I guess they have been considered minor issues by the team during the review. Done in ~https://github.com/trento-project/web/pull/2930/commits/4359d5ca2de8b733150117e5f26b30de737e3771~ https://github.com/trento-project/web/pull/2930/commits/a65591efd5b3d616404cf1e42d4b5ecca3749cde

changing results per page should keep previously applied filters navigating backwards or forward in the activity log should retain previously applied filters

It should already be like this, have you found something different while trying? if so it's not intended, it's a bug.

nelsonkopliku commented 2 months ago

It should already be like this, have you found something different while trying? if so it's not intended, it's a bug.

I tried the most obvious things: Scenario 1:

  • filter by an activity type (which returns a long enough list to be paginated)
  • navigate on next page

The first request has the type, the second one has first and after, but not the previously selected type (also date filters are lost)

Scenario 2:

The first request has the type, the second one has only first, but not the previously selected type (also date filters are lost)


I added such a requirement to prevent unclear experiences for users

Maybe I am missing some cases where things go weird :eyes: I also got some edge cases while implementing this https://github.com/trento-project/web/pull/2887/files maybe there is something useful there?

EDIT: anyway I guess that resetting pagination on filter change could be acceptable, as long as we keep filters while paginating.

nelsonkopliku commented 2 months ago

Maybe I am missing some cases where things go weird 👀 I also got some edge cases while implementing this https://github.com/trento-project/web/pull/2887/files maybe there is something useful there?

EDIT: anyway I guess that resetting pagination on filter change could be acceptable, as long as we keep filters while paginating.

@balanza I guess there might be some misunderstanding about keep previously applied pagination. That means keeping the previously applied Results per page, which does not conflict with what you mentioned in the PR's description

when filters change, the pagination is reset to the first page

which is still valid and the way to go.

Anyway it's a minor thing, I don't mind much if when applying new filters we reset Results per page to the default of 20, as long as we keep filters while navigating pages.

nelsonkopliku commented 2 months ago

Hey @balanza, in your absence I tried addressing what we were discussing in the last two commits.

However, let's check in together when you're back. I am sure that together we can improve :smile:

balanza commented 1 month ago

Closing this as the suggestion will be addressed in #2960, #2961 and #2967 for more-scoped activities.