trentool / TRENTOOL3

Open-Source MATLAB toolbox for transfer entropy estimation
http://trentool.github.io/TRENTOOL3/
GNU General Public License v3.0
56 stars 26 forks source link

A problem in the TEtrialselect.m #22

Open DarcyZhuoLiu opened 7 years ago

DarcyZhuoLiu commented 7 years ago

Dear, Thank you for providing the TRENTOOL. This toolbox is very powerful. I am studying this toolbox to solve an issue by means of transfer entropy. My version is the latest one, 3.4.X, just downloaded a few days ago. In the script named 'TEtrialselect.m', in my opinion, there is a bug in the 59th line, 'trialselect = find(ACT(ii,2,:)>actthreshold(1) & ACT(ii,2,:)<=actthreshold(2));' This code should be modified as follows: 'trialselect = find(ACT(ii,pp,:)>actthreshold(1) & ACT(ii,pp,:)<=actthreshold(2));' I think '2' should be replaced by 'pp'.

I hope sincerely that you can check it. If I am wrong, I am very sorry for that. Thank you.

DarcyZhuoLiu commented 7 years ago

It seems that I understand your intention like this. It will make sure that two channels in one pair of channel combination derive from the same trial. This is a great work!