search

trentrand / cypress-utils

⚙ Easily parallelize and stress-test your Cypress tests
MIT License
25 stars 6 forks source link

Add fileFormat and testFiles args along #11

Closed SamWyldKW closed 3 years ago

SamWyldKW commented 3 years ago

Hey, this PR adds fileFormat as an option. This is because we are using TypeScript, it's very useful to have the option. As well as that, I found that files were not loading in as testFiles were not set in my cypress.json. I've added testFiles as an arg with the default that cypress sets.

I've also added the use of glob. It easily enables me to work with my nested test suite structure without having any effect on the current functionality.

SamWyldKW commented 3 years ago

@trentrand Hi, thanks for the feedback :D I've addressed all of your comments just have one question 👍

trentrand commented 3 years ago

@SamWyldKW I addressed the last feedback but unfortunately I can't amend this PR because the branch is owned by you.

Do you mind clicking this checkmark so that I have contribution permissions?

image

I'll push the change and get this merged shortly after!

SamWyldKW commented 3 years ago

Hey I have it checked. You should be able to 👍 @trentrand

trentrand commented 3 years ago

How strange image

trentrand commented 3 years ago

@SamWyldKW I lost permission to your branch again so I went ahead and just pushed your commit (https://github.com/trentrand/cypress-utils/commit/76dd45b14130c8456d343d3c3b9419315c4638d8) directly to master.

I've tested it locally and it works great - thank you very much for the contribution!

trentrand commented 3 years ago

Published as cypress-utils@2.1.0 on npm registry and Github packages.