trentrichardson / jQuery-Timepicker-Addon

Adds a timepicker to jQueryUI Datepicker
http://trentrichardson.com/examples/timepicker/
MIT License
2.66k stars 1.04k forks source link

stepMinute, stepSecond, step etc #665

Open sherakama opened 10 years ago

sherakama commented 10 years ago

It is possible for a user to pass a string to the stepXXXX options. When it does line 989 (for each function) concatenates the strings so something like this may happen.

min = 0 max = 55 step = 5

Loop one: i = 0 Loop two: i = 05 Loop three i = 055 breaks...

should be Loop one: i=0 Loop two: i=5 Loop three: i=15 etc..

Add validation that the step option parameters are integers and not strings.

sherakama commented 10 years ago

slight typo in above:

Loop one: i=0 Loop two: i=5 Loop three: i=10 Loop four: i=15