search

trentrichardson / jQuery-Timepicker-Addon

Adds a timepicker to jQueryUI Datepicker
http://trentrichardson.com/examples/timepicker/
MIT License
2.66k stars 1.05k forks source link

Timepicker is overriding datetimepicker #748

Open gummz opened 10 years ago

gummz commented 10 years ago

So I'm using both datetimepicker and Timepicker. I want to be able to call both datetimepicker (this one: http://eonasdan.github.io/bootstrap-datetimepicker/) and timepicker, but when I call datetimepicker, Timepicker is called instead. How can I call datetimepicker, and not the one inside Timepicker?

trentrichardson commented 10 years ago

This is caused by overlapping names. You could probably comment out the timepicker if you really wanted to here:

https://github.com/trentrichardson/jQuery-Timepicker-Addon/blob/master/dist/jquery-ui-timepicker-addon.js#L1086

But that only gets rid of timepicker, not datetimepicker. You couldn't do the other way around because timepicker depends datetimepicker (this library, not the bootstrap version)

I would highly suggest picking one library or the other and stick with it. Otherwise you're bound to encounter more issues since they named their project the same as this one. Not to mention every time you need to update your libraries you have to repeat the process.

gummz commented 10 years ago

What if I change datetimepicker to datetimepicker2?

You're right that I should just stick to one. I think I'll end up doing that.

On Fri, Aug 8, 2014 at 5:42 PM, Trent Richardson notifications@github.com wrote:

This is caused by overlapping names. You could probably comment out the timepicker if you really wanted to here:

https://github.com/trentrichardson/jQuery-Timepicker-Addon/blob/master/dist/jquery-ui-timepicker-addon.js#L1086

But that only gets rid of timepicker, not datetimepicker. You couldn't do the other way around because timepicker depends datetimepicker (this library, not the bootstrap version)

I would highly suggest picking one library or the other and stick with it. Otherwise you're bound to encounter more issues since they named their project the same as this one. Not to mention every time you need to update your libraries you have to repeat the process.

Reply to this email directly or view it on GitHub https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/748#issuecomment-51634231 .

trentrichardson commented 10 years ago

Yep that would be my suggestion, stick to one or the other. Not being biased, stick with what fits best with your project.