Open mdprw opened 8 years ago
Is this backward compatible with jQuery UI 1.11? Because I dont see controlgroup
being declared in 1.11 for this to work.
This is not backwards compatible according to the author of the pull request:
https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/891
Work will need to be done to make it compatible, or draw a line in the sand declaring support only for jquery ui 1.12+. I'd prefer it be backwards compatible, but I would have to look at the required changes.
@Jupakabra @trentrichardson This PR is not compatible with jQuery UI 1.11:
If you want to support older versions you should detect if the user is using version 1.12 and set $.uiBackCompat flag to false (which "disables" API for version 1.11) to provide the code of this PR and apply the changes to the stylesheet. Otherwise use the old code and css.
I'm using UI lightness Theme and i noticed that the icon used in the combo to open the dropdown ".ui-icon-triangle-1-s" is moved one pixel to left, so to set icon to the same exact position as before you'll have to update jQuery UI stylesheet accordingly.