Uploading results after budget fails

[shortcircuit3]

Is this correct that the upload does not proceed if the budget fails? In your examples it looks like the budget uploads.

My workflow

name: CI

on: push

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v1

    - name: Lighthouse CI Action
      uses: treosh/lighthouse-ci-action@v1
      with:
        urls: 'http://milesalex.github.io/gatsby'
        budgetPath: .github/workflows/budget.json

    - name: Upload results
      uses: actions/upload-artifact@master
      with:
        name: lighthouse-results
        path: './results'

[shortcircuit3]

and repo: https://github.com/milesalex/gatsby/actions

[alekseykulikov]

Hey @milesalex! Thank you for the report. I agree it's a bug, that the action fails and you can't debug the results. Have you tried continue-on-error option?

Also, have you taken a look at today's @v2 release? It has temporaryPublicStorage: true option and supports much more advanced assertions format.

[shortcircuit3]

I'll check these out. Thank you for the reply!

[alekseykulikov]

Current solution is https://github.com/treosh/lighthouse-ci-action/issues/10#issuecomment-552522161. At #2 we discuss our options and will be happy to hear your input.

[shortcircuit3]

are the units fixed in v2?

[alekseykulikov]

if you refer to https://github.com/treosh/lighthouse-ci-action/issues/13 than yes :)