search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.17k stars 82 forks source link

v2 budget assertions seem wrong #13

Closed shortcircuit3 closed 4 years ago

shortcircuit3 commented 4 years ago

One more thing...

I just tested with the NPM module and I have set my budgets correctly:

image

The 1KB over budged is expected. Using this action All my budgets are failing and I dont know what scale the numbers are in

image

denar90 commented 4 years ago

Hey @milesalex. First of all, sorry for the delay and thank you for pointing out the issue.

So, actually there are 2 problems:

  1. Assertion for resource-summary compared Kilobytes (values set via budget config) and Bytes (values measured from the site). It's fixed now in LHCI and after release will be fixed in Action.
  2. What you will still see - numbers without actual unit symbol. It has to be handled by https://github.com/GoogleChrome/lighthouse-ci/issues/100. But for now, values you see in console are bytes.
alekseykulikov commented 4 years ago

Fixed by the recent release, see the recipe for more details: https://github.com/treosh/lighthouse-ci-action/actions?query=workflow%3ALHCI-assert-on-budget