search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.15k stars 81 forks source link

Action incorrectly failing when using `includePassedAssertions` #130

Closed KaiDoering closed 3 months ago

KaiDoering commented 1 year ago

When the flag includePassedAssertions is used in lighthouserc the action will fail, because it is assumed that the assertion result files only contains failed results. Filtering for results with passed: false should fix this.

Minimal lighthouserc.js to reproduce:

module.exports = {
    ci: {
        assert: {
            includePassedAssertions: true,
            assertions: {
                "categories:performance": ["error", { minScore: 0.01 }],
            },
        },
    },
};
gregoriopalama commented 3 months ago

Any plan on when this will be merged?

alekseykulikov commented 3 months ago

Merged and updated v11