Add Slack notifications and Github Check integration

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.

MIT License

1.16k stars 82 forks source link

Add Slack notifications and Github Check integration #22

Closed denar90 closed 4 years ago

denar90 commented 4 years ago

Following up with #2

UPD:

added GH Check Suite integration
refactored all previous stuff implemented for Slack
notifications in Slack even without GH token
simultaneous runs for Slack and Github notifications

Todo:

[x] Docs, massive updated with all new stuff
[ ] Improve jsdoc
[x] Fix issue with link to results, now for multiple URLs data to Gist sent only for the first one
[x] Following up gist changes, create gists with url name included
[ ] Fix todos comments

Dogfooding results of current status.

denar90 commented 4 years ago

@exterkamp sorry for long long long delay. I had so many stuff to be done before NY. Hope you guys had also a good vac 🌴

denar90 commented 4 years ago

PDT: Saving to gist just done for the first run of action in the repo. Next runs will just update version of the gist instead of creating new one

denar90 commented 4 years ago

Sorry for the noise. Formatting GH Suite is hard :) Updates in description ☝️

exterkamp commented 4 years ago

Is this ready for a final review?

denar90 commented 4 years ago

Yeah, I'd really appreciate that. Thanks :)

denar90 commented 4 years ago

Landing it in next branch, will follow up with fixes and updates against that branch. @exterkamp @alekseykulikov thank you guys for the review.

thedaviddias commented 3 years ago

I was trying to find this merge in master, but it seems that it was merged to the next branch and the next branch was merged around March 2020. What am I missing? Did the Slack and Github integration got removed?

alekseykulikov commented 3 years ago

Hey @thedaviddias, yes, we then removed this PR. It's easier to compose LHCI action with separate actions to achieve extra functionality.

thedaviddias commented 3 years ago

Hi @alekseykulikov, ok sounds good. Thanks for letting me know! 🙏