search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.16k stars 82 forks source link

Fix misplaced env config in workflow example #25

Closed arnellebalane closed 4 years ago

arnellebalane commented 4 years ago

In the workflow example showing interpolation of process env variables, the env config is placed inside with. However, this is invalid and will cause the following error when the workflow runs:

### ERRORED 16:17:51Z

- Your workflow file was invalid: The pipeline is not valid. .github/workflows/lighthouse.yml (Line: 30, Col: 13): A mapping was not expected

This PR places the the env config in the same hierarchy as the with config, where it should be.

alekseykulikov commented 4 years ago

Great catch, thank you, Arnelle!