search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.16k stars 82 forks source link

Allow setting URLs in from lighthouse config JSON #29

Closed orta closed 4 years ago

orta commented 4 years ago

lighthouse-ci has the option url in collect which allows setting your own URLs. From their samples:

{
  "ci": {
    "collect": {
      "startServerCommand": "rails server -e production",
      "url": [
        "http://localhost:3000/",
        "http://localhost:3000/pricing",
        "http://localhost:3000/support"
      ]
    }
  }
}

This means instead of using the ENV var interpolation, I can switch to making a lighthouse-ci.json file ahead of time in the CI process

alekseykulikov commented 4 years ago

Hey @orta thank you for PR! Sorry for the delay, we've been hacking on a big update (https://github.com/treosh/lighthouse-ci-action/tree/next) and hope to release it the next week

orta commented 4 years ago

No a problem, it has been easy to use my fork - looking forwards to seeing the new versions 👍