search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.15k stars 82 forks source link

Add puppeteerScript and disableStorageReset #39

Closed piotrmoszkowicz closed 4 years ago

piotrmoszkowicz commented 4 years ago

Hello! I wanted to use the action with my React App, which has authorization system. Therefor I need to have puppeteerScript and in my case disableStorageReset parameters (using localStorage for creds). I've added these two into the action. As this is my first contribution feel free to ask question / tell tips, which should be taken into consideration before merging. Would be nice to get it done fast as I want to use it on my prod app :)

Regards, Piotr.

piotrmoszkowicz commented 4 years ago

@alekseykulikov Done ;)

alekseykulikov commented 4 years ago

I would propose to close this PR and start from scratch to avoid prev unrelated fixes. It could be a simple PR with a recipe (documentation change), and a workflow with a real-world example.

piotrmoszkowicz commented 4 years ago

Sure, I will close it now and finish when I have a bit more free time :)