treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.15k stars 82 forks source link

Remove warning for using static_dist_dir with urls #45

Closed gregjopa closed 4 years ago

gregjopa commented 4 years ago

This PR removes the warning around using urls with a static dist directory. Support for this was added to lighthouse-ci in November 2019: https://github.com/GoogleChrome/lighthouse-ci/commit/93b674203a39520d40f6c985048d83d2ed46a2b8.

I set this up for my personal blog which uses Gatsby.js and ran into this warning even though everything's working fine:

Screen Shot 2020-04-07 at 3 11 26 PM

It seems like this warning is unnecessary now.

Also thanks for this awesome project @alekseykulikov and Google Team 💯 It's amazing that this is all free to use.

alekseykulikov commented 4 years ago

Thank you @gregjopa for your kind words and such a well-documented PR ❤️

gregjopa commented 4 years ago

Thanks @alekseykulikov 😄