search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.15k stars 82 forks source link

Update emoji in setFailedAnnotations #49

Closed paulirish closed 4 years ago

paulirish commented 4 years ago

I'm not sure what the '🟡' glyph is, but it renders as a box on my machine.

I was just going to file that as a bug, but I figure why not just adopt the X and warning sign that are used right in the comment above. :)

Open to changing them, but just wanted 2 clear icons for these states.

alekseykulikov commented 4 years ago

Thanks, Paul! I agree with your choice of icons.

Screenshot 2020-04-10 at 10 45 46

It suppose to be a yellow circle :)