search

treosh / lighthouse-ci-action

Audit URLs using Lighthouse and test performance with Lighthouse CI.
MIT License
1.15k stars 82 forks source link

fix case when a.auditProperty is undefined #50

Closed paulirish closed 4 years ago

paulirish commented 4 years ago

Ran into this on a recent run: https://github.com/ChromeDevTools/debugger-protocol-viewer/runs/575487920

image

loooking at https://github.com/GoogleChrome/lighthouse-ci/blob/6329be032572dd236da4eb7b721eb56d82441efc/packages/utils/test/assertions.test.js i see a buncha cases where there's an auditId but no auditProperty

so just tweaking the string construction

alekseykulikov commented 4 years ago

Great catch! Thanks a lot 🚀