Closed exterkamp closed 4 years ago
Awesome feedback, thanks for taking a thorough look ❤️! I fixed most things inline and resolved comments. There are a few outstanding for your consideration still. And the rest is answered here!
let's use camelCase for consistency with other configs
sgtm
let's keep it private and cheap to run by default
This sounds good, but once anyone wants to get serious about asserting, they need minimum 3 runs to avoid a flaky VM.
we need some consensus on the config option and default path for lighthouserc.json (GoogleChrome/lighthouse-ci#48).
until that gets resolved, then I think keeping us tagged to 0.3.0-alpha
and waiting is a good plan?
it's going to be published under
@next
(until LHCI is in alpha) to keep@v1
users untouched.
👍
instead of offering many configuration options, I would ask users to use lighthouserc.json, and use .yml only for Github Action specific stuff, like env variables or special options.
sgtm, good idea!
merge support fot env vars interpolation from master.
Done, never used the Github merge UI. Was cool.
This changes the underlying library from Lighthouse to Lighthouse CI
✨ New features ✨
budgets.json
assertions.temporary-public-storage
static-build-dir
🚩 Things that changed 🚩
📋 Things that stayed the same 📋
budgets.json
supportFor convenience of reviewing this PR, we removed all changes within
node_modules
. After this PR is landed (squash works for us), ayarn install
will update thenode_modules
to add LHCI and it's dependencies.👩💻
TODOs
👨💻yarn install && git commit