tresinformal / basketball

Trêsinformal's 2024 team basketball game
GNU General Public License v3.0
0 stars 0 forks source link

Issue 26 - The game has a screen size #46

Closed TheoPannetier closed 10 months ago

TheoPannetier commented 10 months ago

We decided to split get_screen_size() into two functions, get_screen_width() and get_screen_height(), because it is not intuitive what a screen "size" is. We also set default values to 720:1280 by default.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a7f899b) 100.00% compared to head (86b820a) 100.00%.

:exclamation: Current head 86b820a differs from pull request most recent head 8f6f7b7. Consider uploading reports for the commit 8f6f7b7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #46 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 63 58 -5 ========================================= - Hits 63 58 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martprenger commented 10 months ago

sorry a bracket was missing fixed the problem