tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Fixed issue #376 #438

Closed Tingvall closed 2 years ago

Tingvall commented 2 years ago

Me and Richel got it to work on mac, that is the new stuff. Ignore in review.

richelbilderbeek commented 2 years ago

@Tingvall: I do agree that the .pro files can be ignored in the review, but the #ifdef USE_MACs should be removed before merging to develop I think. Who wrote that in the first place :smirk:?

codecov-commenter commented 2 years ago

Codecov Report

Merging #438 (4cca3f2) into develop (1209f73) will increase coverage by 0.82%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #438      +/-   ##
===========================================
+ Coverage    93.02%   93.84%   +0.82%     
===========================================
  Files           44       44              
  Lines         2195     2504     +309     
  Branches       128      149      +21     
===========================================
+ Hits          2042     2350     +308     
- Misses         153      154       +1     
Impacted Files Coverage Δ
main.cpp 94.82% <ø> (ø)
menu_button.h 100.00% <ø> (ø)
read_only.cpp 100.00% <100.00%> (ø)
read_only.h 85.71% <100.00%> (-14.29%) :arrow_down:
game.h 100.00% <0.00%> (ø)
game.cpp 95.89% <0.00%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1209f73...4cca3f2. Read the comment docs.

kausmees commented 2 years ago

We removed one of the functions, and renamed the other one get_value(). And changed the return to a const reference. Also removed the preprocessor #ifdef USE_MAC directives from all files, and it worked when we tested on a mac!