search

tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Fix issue #474 #475

Closed kausmees closed 2 years ago

kausmees commented 2 years ago

Added preprocessor directives to use different functions dependent on the SFML version.

codecov-commenter commented 2 years ago

Codecov Report

Merging #475 (13b82f6) into develop (9e12dca) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #475   +/-   ##
========================================
  Coverage    93.01%   93.01%           
========================================
  Files           45       45           
  Lines         2247     2247           
  Branches       132      132           
========================================
  Hits          2090     2090           
  Misses         157      157

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e12dca...13b82f6. Read the comment docs.

kausmees commented 2 years ago

Oops, I realized this code won't work for SFML major versions > 2 (then there should be no constraint on the minor version), so that should probably be fixed before accepting the pull request.

richelbilderbeek commented 2 years ago

@kausmees the tests pass and we have the mantra 'If all tests pass, we are -by definition- happy'. Sure, if team members discover their build fails, we'll fix it :-)

TheoPannetier commented 2 years ago

Oops, I realized this code won't work for SFML major versions > 2 (then there should be no constraint on the minor version), so that should probably be fixed before accepting the pull request.

I pushed a change solving this with an elif 😉