Closed decommandpro closed 2 years ago
I feel this should be merged to develop already. I ruthlessly took the initiative to suggest a reviewer :-)
Merging #480 (54c057f) into develop (2bb2df7) will increase coverage by
0.17%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## develop #480 +/- ##
===========================================
+ Coverage 93.08% 93.26% +0.17%
===========================================
Files 46 46
Lines 2243 2554 +311
Branches 132 158 +26
===========================================
+ Hits 2088 2382 +294
- Misses 155 172 +17
Impacted Files | Coverage Δ | |
---|---|---|
game_resources.cpp | 0.00% <0.00%> (ø) |
|
game_resources.h | 0.00% <ø> (ø) |
|
sound_type.cpp | 93.33% <92.85%> (-6.67%) |
:arrow_down: |
main.cpp | 92.64% <0.00%> (-2.36%) |
:arrow_down: |
game.cpp | 96.89% <0.00%> (+0.95%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2bb2df7...54c057f. Read the comment docs.
Successfully merged.
Hey @decommandpro does the WIP here means this isn't ready to be merged?
if (TRUE) here's a pro tip: you can convert the PR to a draft, which will prevent anyone from merging and closing the PR + tell clearly that you're still working on it 😇 else You can request 1-3 reviewers to have a look and merge your branch. Otherwise I fear you may wait for a while