tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Progress in saving a `key_action_map`, #522 #523

Closed richelbilderbeek closed 2 years ago

richelbilderbeek commented 2 years ago

Here is some stub code to implement #522 as criticized during the mob programming by me at 2022-04-06. It is not complete, but the tests and function declarations are there.

Also the excess output (#526) is removed :-)

codecov-commenter commented 2 years ago

Codecov Report

Merging #523 (e81b597) into develop (a743d58) will decrease coverage by 1.39%. The diff coverage is 11.36%.

@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
- Coverage    93.52%   92.12%   -1.40%     
===========================================
  Files           46       46              
  Lines         2594     2629      +35     
  Branches       165      167       +2     
===========================================
- Hits          2426     2422       -4     
- Misses         168      207      +39     
Impacted Files Coverage Δ
key_action_map.cpp 78.94% <0.00%> (-20.40%) :arrow_down:
key_action_map.h 100.00% <ø> (ø)
color.cpp 98.14% <100.00%> (-0.02%) :arrow_down:
enemy_behavior_type.cpp 94.44% <100.00%> (ø)
player_state.cpp 100.00% <100.00%> (ø)
sound_type.cpp 95.45% <100.00%> (-0.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a743d58...e81b597. Read the comment docs.

richelbilderbeek commented 2 years ago

Hi @EvoLandEco, thanks for the review. Feel encouraged to request more changes :-) . Else: go ahead and merge it to develop. I assume you know you are responsible if develop breaks :sunglasses: :+1:

richelbilderbeek commented 2 years ago

Hi @EvoLandEco, thanks for the first review round. I'll make sure develop does not break, as well as taking a closer look at a comment :-)

richelbilderbeek commented 2 years ago

This PR is sitting idle for too lomg now. I feel it has been reviewed enough, I will merge it and even take responsibility for the merge :-)