search

tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Implement scoring board and embed it into `game` and `game_view` #544

Closed EvoLandEco closed 2 years ago

EvoLandEco commented 2 years ago

Fixes #542

codecov-commenter commented 2 years ago

Codecov Report

Merging #544 (2430ac1) into develop (9584e6b) will decrease coverage by 1.52%. The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
- Coverage    92.15%   90.63%   -1.53%     
===========================================
  Files           49       51       +2     
  Lines         2755     2819      +64     
  Branches       194      195       +1     
===========================================
+ Hits          2539     2555      +16     
- Misses         216      264      +48
Impacted Files Coverage Δ
player.cpp 99.05% <ø> (ø)
scoring_board.cpp 6.81% <6.81%> (ø)
scoring_board.h 22.22% <22.22%> (ø)
game.cpp 96.95% <100.00%> (+0.03%) :arrow_up:
game.h 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

TheoPannetier commented 2 years ago

@EvoLandEco why is this PR is labelled with depends?

We use this label to indicate that an issue/PR can't be solved currently, because it requires another issue or PR to be closed first. For example, #463 depends on #381 because invulnerability status first needs to be implemented if we then want to make it disappear after some time, so with the depends label we let contributors now that they would need to solve the latter before tackling the former.

I feel this is unjustified here?

richelbilderbeek commented 2 years ago

@EvoLandEco : I asked Theo and Oliver to take over the tiangjian branch, as this PR slows us the team down for already a month, and I cannot be sure to see you soon.

I know it may feel a bit rude to have your branch taken over, but I hope you will agree that in this context it's better for the team. We just want to get that scoreboard in :-)