tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Menu task force ready to report ✌️ #546

Closed TheoPannetier closed 2 years ago

TheoPannetier commented 2 years ago

View switching is now operational... mostly.

Fixes:

This PR raises one issue, however: all windows for game_view, menu_view, options_view... are created at the beginning, regardless of whether the corresponding view is in use or not. This also means that we can only switch once between two views, and not back and forth yet. See #545. Solving this will require rethinking the implementation of the view classes, and I feel this PR is big enough already 😇

codecov-commenter commented 2 years ago

Codecov Report

Merging #546 (1ea73ae) into develop (841f59d) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #546      +/-   ##
===========================================
+ Coverage    90.79%   90.81%   +0.01%     
===========================================
  Files           47       48       +1     
  Lines         2672     2677       +5     
  Branches       168      168              
===========================================
+ Hits          2426     2431       +5     
  Misses         246      246              
Impacted Files Coverage Δ
menu.h 100.00% <ø> (ø)
main.cpp 95.16% <100.00%> (+0.07%) :arrow_up:
menu.cpp 100.00% <100.00%> (ø)
view_mode.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 841f59d...1ea73ae. Read the comment docs.

richelbilderbeek commented 2 years ago

Ha, I see the problems :-)

Screenshot from 2022-05-18 16-52-10

Whatever needs to be done, the game is still in a runnable state :-)

TheoPannetier commented 2 years ago

Ah, can't seem to find the comment in view_mode.cpp 😅