tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Windows drawn successively, not simultaneously #548

Closed TheoPannetier closed 2 years ago

TheoPannetier commented 2 years ago

Depends on:

Fixes:

Windows are no longer all opened at the beginning at the game*, only when one switches to the corresponding _view. So if one starts with game and presses [Esc], game window closes and menu window opens.

*well they are, but they are closed immediately after setup (constructor) is done.

codecov-commenter commented 2 years ago

Codecov Report

Merging #548 (318ec75) into develop (76f0ae1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #548      +/-   ##
===========================================
+ Coverage    92.10%   92.11%   +0.01%     
===========================================
  Files           48       49       +1     
  Lines         2735     2739       +4     
  Branches       193      193              
===========================================
+ Hits          2519     2523       +4     
  Misses         216      216              
Impacted Files Coverage Δ
game.cpp 96.90% <ø> (ø)
key_action_map.cpp 88.80% <ø> (ø)
menu.cpp 100.00% <ø> (ø)
main.cpp 95.23% <100.00%> (+0.07%) :arrow_up:
view_manager.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76f0ae1...318ec75. Read the comment docs.

richelbilderbeek commented 2 years ago

It is hard to quit (but well, who wants that anyways ;-) ), maybe we'll create an Issue later.

Screenshot from 2022-05-18 18-22-17

TheoPannetier commented 2 years ago

@richelbilderbeek what do you mean? Is it hard to click, or does the quit button not work properly?

TheoPannetier commented 2 years ago

Ah, I see what I missed

richelbilderbeek commented 2 years ago

I have added one commit to be able to display the game in release mode; it did not compile otherwise. Now, in release mode, a warning is simply a warning, that is, not an error.