search

tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Some housekeeping #569

Closed TheoPannetier closed 2 years ago

TheoPannetier commented 2 years ago

Depends on:

Fixes:

TheoPannetier commented 2 years ago

Yes, I wasn't very strict with the rule. Plan is to

  1. Remove any leftover preprocessor directives on fixed tests
  2. Link test to issue number, if exists

Ideally, Each test should also have an accompanying description, but it should have been done before and would have been a much more difficult task to hunt down through issues to fix this. I'm not strong on how to label number either, as long as it's there; or whether to put the test title before or after the opening bracket.

If you want to enforce a stricter rule, we can suggest it to the group after the summer break :)

Regarding indentation, I agree there's an issue, but it would too much for this issue to fix all indentation mistakes in the code

TheoPannetier commented 2 years ago

About indentation, we had a debate some time in the past and decided to set it to two spaces; but this has not been enforced in the game as you can see. Setting up a lint routine (#201) could help with that.

codecov-commenter commented 2 years ago

Codecov Report

Merging #569 (ad74680) into develop (0f12d61) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ad74680 differs from pull request most recent head 0b87b2e. Consider uploading reports for the commit 0b87b2e to get more accurate results

@@            Coverage Diff            @@
##           develop     #569    +/-   ##
=========================================
  Coverage    92.13%   92.13%            
=========================================
  Files           49       49            
  Lines         2748     2748            
  Branches       193        0   -193     
=========================================
  Hits          2532     2532            
  Misses         216      216
Impacted Files Coverage Δ
coordinate.cpp 100.00% <ø> (ø)
enemy.cpp 100.00% <ø> (ø)
environment.cpp 100.00% <ø> (ø)
food.cpp 100.00% <ø> (ø)
game.cpp 96.92% <ø> (ø)
game_options.cpp 100.00% <ø> (ø)
key_action_map.cpp 88.80% <ø> (ø)
player.cpp 99.05% <ø> (ø)
player_profession.cpp 0.00% <ø> (ø)
player_state.cpp 100.00% <ø> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.