tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Tests for Milestone 3: killing and reviving player #629

Closed TheoPannetier closed 1 year ago

TheoPannetier commented 1 year ago

I have made a bunch of tests from the chat we had with @ollyturner last week, to translate the ideas from the game design team into actual issues. There is a bunch more to do, but this is good to go on develop so that juniors can start solving the issues :)

Tests for:

I also went ahead and already fixed #627 😇

codecov-commenter commented 1 year ago

Codecov Report

Merging #629 (96afe72) into develop (efc4f17) will increase coverage by 0.51%. The diff coverage is 95.83%.

@@             Coverage Diff             @@
##           develop     #629      +/-   ##
===========================================
+ Coverage    90.80%   91.31%   +0.51%     
===========================================
  Files           50       50              
  Lines         2870     2879       +9     
  Branches       197      195       -2     
===========================================
+ Hits          2606     2629      +23     
+ Misses         264      250      -14     
Impacted Files Coverage Δ
color.cpp 98.14% <ø> (ø)
game.h 100.00% <ø> (ø)
game_functions.cpp 87.85% <0.00%> (ø)
player.h 100.00% <ø> (ø)
action_type.cpp 100.00% <100.00%> (ø)
game.cpp 98.42% <100.00%> (+1.46%) :arrow_up:
player.cpp 99.11% <100.00%> (+0.03%) :arrow_up:
player_state.cpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.